Fix noble wheel packaging globs#32
Merged
mutability merged 1 commit intoflightaware:ubuntu-packagingfrom Apr 4, 2026
Merged
Conversation
Contributor
|
Thanks! I wonder if this will break the actual trixie build, but I don't have a simple way of doing a test build against a PR from an external branch without actually merging the PR so I'll just merge this and see what breaks.. |
Contributor
|
This does break the trixie build (but not for the reason I expected) setuptools complains about the (patched) license description, but continues anyway: The glob change fails on trixie: |
Contributor
|
Some brief research suggests that this is about setuptools/wheel originally not normalizing wheel filenames (which includes forcing them to lowercase), and newer versions now do. Yay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the Ubuntu 24.04 (noble) packaging path for piaware.
The build was failing in the vendored Python packaging steps used for mlat-client freezing. Two upstream tarballs, freeze-core-0.4.2 and cx_Freeze-8.5.0, ship pyproject.toml metadata that newer upstream tooling accepts but Ubuntu 24.04’s setuptools rejects.
This change patches both archives during sensible-build.sh preparation so their license metadata is compatible with the distro toolchain. It also fixes the trixie packaging recipe to install the generated wheels using the correct wheel filename patterns for cx_Freeze and MlatClient.
Successfully builds in github actions.