Skip to content

Conversation

ericallam
Copy link

We want to give users the ability to add custom transformers, and for that to work nicely with typescript we need these types. I tried to do export type but prettier threw an error (see prettier/prettier-vscode#2558), so I just exported them as values instead.

@ericallam ericallam requested a review from Skn0tt as a code owner September 19, 2024 10:49
Copy link
Collaborator

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types are implementation details. Could you elaborate on your usecase? Maybe we can find a better solution using some TypeScript tricks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants