Add non-blocking Rails main entry to CI matrix - #1034
Merged
Conversation
Rails main went keyword-only for Arel::Table.new (rails/rails#57021), which broke get_all in the ActiveRecord adapter (#1003) — and nothing in CI could catch it because the matrix only covers released versions. Run ruby 3.3 against rails/rails main as a canary. continue-on-error keeps it from blocking the build when edge Rails breaks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Rails main went keyword-only for
Arel::Table.new(rails/rails#57021), which brokeget_allin the ActiveRecord adapter. The fix landed in #1003, but CI had no way to catch the regression because the matrix only covers released Rails versions.What
ruby 3.3 / rails mainentry to the CI matrix viainclude, installing Rails fromrails/rails@main(currently resolves to 8.2.0.alpha)continue-on-error: ${{ matrix.rails == 'main' }}makes it a non-blocking canary — edge Rails breakage annotates the run but doesn't fail the buildRAILS_VERSION=main, otherwise behaves exactly as beforeSQLITE3_VERSIONuses 2.1.0 for main (same as 8.0.0)Verified locally that
RAILS_VERSION=main bundle lockresolves cleanly.🤖 Generated with Claude Code