Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connector supports filtering and conversion based on service names #756

Open
wants to merge 5 commits into
base: release/v1.5
Choose a base branch
from

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Mar 11, 2025

Description:
connector supports filtering and conversion based on service names

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [X]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [X]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

Copy link
Contributor

mergify bot commented Mar 11, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(\[wip\]|\[backport\]|\[cherry-pick\])?( )?(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 Enforce verified commits

Wonderful, this rule succeeded.

Make sure that we have verified commits

  • #commits-unverified = 0

🟢 Enforce linear history

Wonderful, this rule succeeded.

Make sure that we have a linear history, no merge commits are allowed

  • linear-history

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 637 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.5@9b5c741). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/connector/ctok/aggregate.go 0.00% 149 Missing ⚠️
pkg/connector/ctok/syncer.go 0.00% 147 Missing ⚠️
...g/apis/connector/v1alpha1/zz_generated.deepcopy.go 0.00% 94 Missing ⚠️
pkg/connector/cli/config.go 0.00% 65 Missing ⚠️
pkg/connector/cli/client.go 0.00% 53 Missing ⚠️
pkg/connector/ctok/source.go 0.00% 29 Missing ⚠️
pkg/connector/ctok/job.go 0.00% 15 Missing ⚠️
pkg/connector/ctok/derive.go 0.00% 9 Missing ⚠️
pkg/apis/connector/v1alpha1/types.go 0.00% 7 Missing ⚠️
pkg/connector/context.go 0.00% 7 Missing ⚠️
... and 17 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.5     #756   +/-   ##
===============================================
  Coverage                ?   11.73%           
===============================================
  Files                   ?      929           
  Lines                   ?    67395           
  Branches                ?        0           
===============================================
  Hits                    ?     7909           
  Misses                  ?    59413           
  Partials                ?       73           
Flag Coverage Δ
unittests 11.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Cybwan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants