filter_logs_to_metrics: document field_value usage for counters#1584
Open
databus23 wants to merge 3 commits intofluent:masterfrom
Open
filter_logs_to_metrics: document field_value usage for counters#1584databus23 wants to merge 3 commits intofluent:masterfrom
databus23 wants to merge 3 commits intofluent:masterfrom
Conversation
This documents a feature added with this PR: fluent/fluent-bit#10055 Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
4 tasks
Member
alexakreizinger
left a comment
alexakreizinger
left a comment
There was a problem hiding this comment.
hi @databus23, thanks for submitting a docs PR! I just suggested a few edits for clarity and consistency.
Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Fabian Ruff <fabian@progra.de>
Author
|
@alexakreizinger thanks for the feedback. I merged in all your suggestions. |
alexakreizinger
approved these changes
Mar 12, 2025
Member
alexakreizinger
left a comment
alexakreizinger
left a comment
There was a problem hiding this comment.
awesome, thank you :) I'm approving this, but I won't merge anything since it sounds like we're still waiting on a different code PR—feel free to merge this one when the time comes.
lecaros
added
waiting-for-user
Collaborator
|
@databus23 can you resolve the conflicts please as I've also nudged the review on code PR fluent/fluent-bit#10055, so I can merge this when it's ready? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
Contributor
|
The conflicts were due to formatting changes for style, I went ahead and fixed the conflicts in the interest of keeping things moving. |
esmerel
removed
conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents a feature added with this PR: fluent/fluent-bit#10055