Skip to content

docs: pipeline: outputs: opentelemetry: document metrics_max_datapoints - #2697

Open
eschabell wants to merge 1 commit into
fluent:masterfrom
eschabell:erics_out_opentelemetry_update
Open

docs: pipeline: outputs: opentelemetry: document metrics_max_datapoints#2697
eschabell wants to merge 1 commit into
fluent:masterfrom
eschabell:erics_out_opentelemetry_update

Conversation

@eschabell

@eschabell eschabell commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Eric D. Schabell eric@schabell.org

Summary by CodeRabbit

  • Documentation
    • Documented the metrics_max_datapoints setting for OpenTelemetry output.
    • Added guidance on metric batching, including payload splitting, request ordering, and failure handling.

@eschabell
eschabell requested review from a team and patrick-stephens as code owners September 5, 2026 13:00
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: a700c45e-a564-4d1d-90b6-07db57fc0020

📥 Commits

Reviewing files that changed from the base of the PR and between d78b75b and 152a7b7.

📒 Files selected for processing (1)
  • pipeline/outputs/opentelemetry.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: c865b369-215c-4fca-afb4-5ca4509d59cd

📥 Commits

Reviewing files that changed from the base of the PR and between aa409a6 and d78b75b.

📒 Files selected for processing (1)
  • pipeline/outputs/opentelemetry.md

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The OpenTelemetry output documentation adds the metrics_max_datapoints parameter and describes metric payload splitting, ordering, validation, partial success, and retry behavior.

Changes

OpenTelemetry metrics batching

Layer / File(s) Summary
Document metrics batching behavior
pipeline/outputs/opentelemetry.md
Adds metrics_max_datapoints to the parameter table and documents its default, validation, supported version, request splitting, ordering, partial-success handling, and retry behavior.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to d78b7

The documentation describes the metrics_max_datapoints setting and its batching and retry behavior without changing runtime behavior. No current merge-readiness risk remains.

Suggested reviewers: edsiper, lecaros

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the documentation change for the metrics_max_datapoints configuration option in the OpenTelemetry output.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eschabell eschabell self-assigned this Sep 5, 2026
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.1.2 labels Sep 5, 2026
@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell force-pushed the erics_out_opentelemetry_update branch from d78b75b to 152a7b7 Compare September 5, 2026 14:16
@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens failing on docker container builds....

@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens all the others resolved, but this one is still hanging up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.1.2 waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant