build: only compile simdutf if there is CXX support #10277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDevoogdt
requested review from
celalettin1286,
fujimotos,
niedbalski and
patrick-stephens
as code owners
patrick-stephens
approved these changes
Apr 30, 2025
Collaborator
|
Triggered full build of all targets just to confirm no issues during build with anything so can merge if green. |
cosmo0920
requested changes
May 1, 2025
Commit 3b04755 "build: lib: Bundle simdutf amalgamation v5.5.0", added support for simdutf, and enforces CXX support if FLB_UNICODE_ENCODER is selected. Which is the default case, fix that now. Signed-off-by: Thomas Devoogdt <[email protected]>
ThomasDevoogdt
force-pushed
the
bugfix/only-compile-unicode-encoder-if-cxx-support
branch
from
29c4de0 to
e480328
Compare
Contributor
Author
|
@cosmo0920 I reworked this PR so that it is functional. How I test it: Without CXX support: export CXX=/bin/false
cmake -GNinja -DFLB_PREFER_SYSTEM_LIBS=ON ../
-- Looking for a CXX compiler
-- Looking for a CXX compiler - NOTFOUND
-- CXX compiler not found, disable simdutf.With CXX support: export CXX=/usr/bin/c++
cmake -GNinja -DFLB_PREFER_SYSTEM_LIBS=ON ../
-- Looking for a CXX compiler
-- Looking for a CXX compiler - /usr/bin/c++
-- CXX compiler found, enable simdutf. |
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
May 2, 2025
Commit 3b04755 "build: lib: Bundle simdutf amalgamation v5.5.0", added support for simdutf, and enforces CXX support if FLB_UNICODE_ENCODER is selected. Which is the default case, fix that now. See: fluent#10277 Signed-off-by: Thomas Devoogdt <[email protected]>
ThomasDevoogdt
deleted the
bugfix/only-compile-unicode-encoder-if-cxx-support
branch
Contributor
Author
|
@edsiper Thank you! Can you also have a look at my other PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3b04755
"build: lib: Bundle simdutf amalgamation v5.5.0",
added support for simdutf, and enforces CXX support if FLB_UNICODE_ENCODER is selected. Which is the default case, fix that now.
As requested by #9277 (comment).