Skip to content

Support for Compress option in fb Output forward plugin#1493

Closed
devBmc wants to merge 21 commits intofluent:masterfrom
devBmc:master
Closed

Support for Compress option in fb Output forward plugin#1493
devBmc wants to merge 21 commits intofluent:masterfrom
devBmc:master

Conversation

@devBmc
Copy link
Copy Markdown

@devBmc devBmc commented Mar 7, 2025

What this PR does / why we need it:

This PR is to support Compress option in fluenbit forward Output plugin
fix for 1492

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


devBmc and others added 7 commits March 6, 2025 19:14
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
adding support for compress gzip

Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
@cw-Guo
Copy link
Copy Markdown
Collaborator

cw-Guo commented Mar 7, 2025

@devBmc Thanks so much for your contributions.

Can you please fix the DCO issue before it can be merged? instructions can be found here https://github.com/fluent/fluent-operator/pull/1493/checks?check_run_id=38380700137

@devBmc
Copy link
Copy Markdown
Author

devBmc commented Mar 7, 2025

@devBmc Thanks so much for your contributions.

Can you please fix the DCO issue before it can be merged? instructions can be found here https://github.com/fluent/fluent-operator/pull/1493/checks?check_run_id=38380700137

added signoff in next commit i hope that should fix the issue

Ravi Ghosh and others added 13 commits March 8, 2025 02:14
Signed-off-by: devBmc <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
adding support for compress gzip

Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: devBmc <ghosh.ravi@gmail.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
Signed-off-by: Ravi Ghosh <Ravi_Ghosh@BMC.com>
@devcontributeatgithub
Copy link
Copy Markdown

@cw-Guo any idea what m missing i ca see see the DCO error , need some help

@cw-Guo
Copy link
Copy Markdown
Collaborator

cw-Guo commented Mar 10, 2025

@devcontributeatgithub check the pipeline to see the details: https://github.com/fluent/fluent-operator/pull/1493/checks?check_run_id=38420789516

The following three commits need to be released.

Commit sha: 1bcc9b5, Author: Ravi Ghosh, Committer: Ravi Ghosh; The sign-off is missing.
Commit sha: cfd236d, Author: Ravi Ghosh, Committer: Ravi Ghosh; The sign-off is missing.
Commit sha: 9826811, Author: Ravi Ghosh, Committer: Ravi Ghosh; Expected "Ravi Ghosh Ravi_Ghosh@BMC.com", but got "devBmc ghosh.ravi@gmail.com".

Comment on lines +76 to +78
if f.Compress != nil {
kvs.Insert("Compress", fmt.Sprint(*f.Compress))
}
Copy link
Copy Markdown
Collaborator

@marcofranssen marcofranssen Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devBmc Please run following to resolve the merge conflicts and fix the DCO.

$ git checkout master
$ git pull upstream master --rebase --signoff

During conflict resolution ensure to take current.

Then add following for your newly added field.

Once done we can merge this PR.

Suggested change
if f.Compress != nil {
kvs.Insert("Compress", fmt.Sprint(*f.Compress))
}
plugins.InsertKVString(kvs, "Compress", f.Compress)

@joshuabaird
Copy link
Copy Markdown
Collaborator

Closing due to inactivity. Please re-open if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants