Support both IPv4 and IPv6 addresses in http_listen configuration #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although `fluent-bit` supports IPv6, HTTP listening on an IPv6 address fails due to the address validation currently supporting IPv4 only. Improve the RegEx to support both IPv4 and IPv6 good enough™ Notes: - the IPv6 RegEx part matches also the unspecified address `::` - the IPv4 RegEx part was improved to match the dot delimiter `.` literally (it previously matched every character, due to missing escaping) Signed-off-by: Damyan Yordanov <[email protected]>
cw-Guo
approved these changes
May 15, 2025
|
@damyan Thanks for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
fluent-bitsupports IPv6, HTTP listening on an IPv6 address fails due to the address validation currently supporting IPv4 only. Improve the RegEx to support both IPv4 and IPv6 good enough™Notes:
::.literally (it previously matched every character, due to missing escaping)Fixes #1615