Update fluentbit-fluentBit.yaml to address issue 1635 #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding imagePullSecrets in fluentbit-fluentBit.yaml, test should be with an "with" instead of a "if" to have the local scope when later using "." See issue fluent#1635 Signed-off-by: g1franc <[email protected]>
cw-Guo
approved these changes
Jun 5, 2025
|
@g1franc good catch. Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding imagePullSecrets in fluentbit-fluentBit.yaml, test should be with an "with" instead of a "if" to have the local scope when later using "." See issue #1635
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1635
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: