Fix error handling #1666
Merged
Fix error handling #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-krauchenco-mottu
approved these changes
Aug 5, 2025
|
@sugaf1204 thanks for the contribution, can you please fix the DCO issue? |
sugaf1204
force-pushed
the
fix/error-handling-fluentd-reconcile
branch
from
974f39c to
cedaded
Compare
Signed-off-by: sugaf1204 <[email protected]>
sugaf1204
force-pushed
the
fix/error-handling-fluentd-reconcile
branch
from
cedaded to
f6e699e
Compare
@cw-Guo |
cw-Guo
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix error handling of Reconcile function.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: