Skip to content

feat: add servicemonitor for fluent-operator to helm chart #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

feat: add servicemonitor for fluent-operator to helm chart #1677

merged 2 commits into from
Sep 8, 2025

Conversation

dennis-ge
Copy link
Contributor

@dennis-ge dennis-ge commented Sep 2, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1671

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

dennis-ge
dennis-ge commented Sep 2, 2025
View reviewed changes
charts/fluent-operator/templates/fluent-operator-servicemonitor.yaml
@@ -0,0 +1,38 @@
{{- if .Values.operator.enable }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied the fluentbit-servicemonitor.yaml and adjusted the labels

charts/fluent-operator/values.yaml
annotations: {}
labels: {}

serviceMonitor:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same config as under fluentbit.serviceMonitor

@dennis-ge
Copy link
Contributor Author

it looks like the Lint and Test Charts action isn't working properly. the output is

Linting charts...
Directory "charts/fluent-operator/templates" is not a valid chart directory. Skipping...
Directory "charts/fluent-operator/templates" is not a valid chart directory. Skipping...
Directory "charts/fluent-operator/templates" is not a valid chart directory. Skipping...
Directory "charts/fluent-operator" is not a valid chart directory. Skipping...

The --chart-dirs parameters expects the chart parent dir, not the chart dir itself. so a change from

ct lint --chart-dirs charts/fluent-operator --config charts/ct.yaml

to

ct lint --chart-dirs charts --config charts/ct.yaml

should fix the github workflow

@joshuabaird
Copy link
Collaborator

@dennis-ge Thanks - this should fix the linting issue: #1680

@joshuabaird joshuabaird merged commit cb12b1a into fluent:master Sep 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuabaird joshuabaird joshuabaird approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add servicemonitor for fluent-operator to helm chart

2 participants

@dennis-ge @joshuabaird