allow s3 output plugin to get keys from secrets

[v-davegillies-upscale]

What this PR does / why we need it:

This allows AwsKeyId and AwsSecKey to be pulled from secrets like the cloudwatch output plugin

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

[cw-Guo]

Hi @v-davegillies-upscale , thanks for your contributions.

By modifying the existing fields' type (AwsKeyId, AwsSecKey), we are introducing a breaking change. Can we try to implement it via a non-breaking way?

For example: adding two new fields called AwsKeyIdFromSecret and AwsSecKeyFromSecret (ignore my naming I just use it as an example)

[v-davegillies-upscale]

Hi @v-davegillies-upscale , thanks for your contributions.

By modifying the existing fields' type (AwsKeyId, AwsSecKey), we are introducing a breaking change. Can we try to implement it via a non-breaking way?

For example: adding two new fields called AwsKeyIdFromSecret and AwsSecKeyFromSecret (ignore my naming I just use it as an example)

I've updated the code and went with your naming suggestion for the fields since its felt clear enough what it was for and I feel a bit unimaginative right now.

[cw-Guo]

can you please run make generate manifests docs-update ?

[v-davegillies-upscale]

can you please run make generate manifests docs-update ?

Done

[cw-Guo]

Hi @joshuabaird , the CI check for helm chart failed due to the fact that the content of the chart changed but not the chart version. Should we ignore the error?

[joshuabaird]

• Lint and Test Charts / lint-test (pull_request)

Yes, please ignore for now.