Try to support prometheus-client 3.0 or later #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
reviewed
Dec 31, 2022
cosmo0920
approved these changes
Dec 31, 2022
|
Thanks for your review! I'll recheck this before merging this (especially the specification of grouping_key). |
Merged
Signed-off-by: Takuro Ashie <[email protected]>
The compatibility was broken since 3.0.0, so it should be >= 3. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
force-pushed
the
support-prometheus-client-3.0+
branch
from
e16d83e to
8d87b9b
Compare
It pass rake spec test with: * prometheus-client 2.1.0 * prometheus-client 3.0.0 * prometheus-client 4.2.4 Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
force-pushed
the
support-prometheus-client-3.0+
branch
from
8d87b9b to
e564d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since initialization parameters of
Prometheus::Client::Pushare changes since prometheus-client v3.0, we need to adapt to it.https://github.com/prometheus/client_ruby/releases/tag/v3.0.0