chore(chart): rename values key runtime.cache to runtime.cacheruntime

[cheyang]

What this PR does

Renames the Helm values key for the CacheRuntime controller: runtime.cache → runtime.cacheruntime.

Why

The sub-keys under runtime: are named after cache engines — alluxio, jindo, juicefs, thin, efc, vineyard. A sibling named cache therefore reads like yet another engine, while CacheRuntime is actually a mechanism: it integrates arbitrary cache systems declaratively through CacheRuntimeClass (topology + executionEntries), rather than being one more built-in engine.

There is also a concrete readability trap: cache in the Kubernetes ecosystem usually means the client-go informer cache, so

runtime:
  cache:
    kubeClientQPS: 20
    workQueueQPS: 10

reads like controller cache tuning rather than settings of the CacheRuntime controller.

runtime.cacheruntime stutters slightly under runtime:, but it lines up exactly with the CRD (cacheruntimes.data.fluid.io), the Deployment (cacheruntime-controller) and the binary, so there is no ambiguity left.

Compatibility

The old key never shipped in a release tag (latest tag is v1.0.8; CacheRuntime exists only on master), so no compatibility shim is needed. Instead the template now fails the render when a stale runtime.cache is present:

Error: UPGRADE FAILED: execution error at (fluid/templates/controller/cacheruntime_controller.yaml:2:4):
values key `runtime.cache` has been renamed to `runtime.cacheruntime`, please update your values file or --set flags

Without that guard the old key would silently render replicas: 0 and scale the controller down with no error at all — which is exactly what happens to anyone on master who keeps runtime.cache.enabled: true in their values.

Verification

Tested against a live 3-node Kubernetes v1.36 cluster running Fluid from master:

1. Rendered output is unchanged. With the chart's defaultVersion pinned to the images the cluster was already running, the manifest produced by helm upgrade --dry-run is byte-identical to helm get manifest fluid (2837 lines, same md5) — the rename touches only the values layer, no rendered object changes.
2. Real upgrade works. helm upgrade succeeded, helm get values now shows runtime.cacheruntime.enabled: true, cacheruntime-controller stayed 1/1 and its pod was not even restarted.
3. Guard works. --set runtime.cache.enabled=true fails loudly (message above); the new key renders replicas: 1; the default renders replicas: 0.

.github/scripts/deploy-fluid-to-kind.sh is updated to the new key as well; no other references to the old key remain in the repo (docs, tests, CI, Makefile all checked).

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[Copilot]

Pull request overview

This PR renames the Helm chart values key for configuring the CacheRuntime controller from runtime.cache to runtime.cacheruntime, aligning the values structure with the controller/CRD naming and reducing ambiguity.

Changes:

• Renamed the runtime.cache values subtree to runtime.cacheruntime in values.yaml.
• Updated the CacheRuntime controller Deployment template to read from runtime.cacheruntime and added a render-time guard for stale runtime.cache usage.
• Updated the Kind deployment helper script to use --set runtime.cacheruntime.enabled=true.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
charts/fluid/fluid/values.yaml	Renames the values subtree and adds clarifying comments for the CacheRuntime controller settings.
charts/fluid/fluid/templates/controller/cacheruntime_controller.yaml	Switches template lookups to runtime.cacheruntime and adds a guard to fail on deprecated runtime.cache.
.github/scripts/deploy-fluid-to-kind.sh	Updates Helm --set usage to the new values key.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cheyang]

Good catch — fixed in ba76963. The guard now tests for the presence of the key instead of a truthy value:

{{- if hasKey .Values.runtime "cache" }}
{{- fail "values key `runtime.cache` has been renamed to `runtime.cacheruntime`, please update your values file or --set flags" }}
{{- end }}

Verified against a live cluster, all of these now fail loudly (only the first one did before):

input	result
--set runtime.cache.enabled=true	fails with the rename message
--set runtime.cache=false	fails with the rename message
runtime.cache: {} in a values file	fails with the rename message
runtime.cache: null in a values file / --set runtime.cache=null	fails with the rename message
--set runtime.cacheruntime.enabled=true	renders replicas: 1
no override	renders replicas: 0

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.08%. Comparing base (44cfae9) to head (ba76963).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6137   +/-   ##
=======================================
  Coverage   65.08%   65.08%           
=======================================
  Files         485      485           
  Lines       33989    33989           
=======================================
  Hits        22122    22122           
  Misses      10126    10126           
  Partials     1741     1741           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xliuqq]

/lgtm

[RongGu]

/lgtm
/approve

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[RongGu]

/lgtm
/approve

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

charts/fluid/fluid/templates/controller/cacheruntime_controller.yaml:3

• hasKey requires its first argument to be a map/dict. If a user supplies an invalid override like runtime: null (or a non-map), this will error out with a type failure before reaching the intended fail message. Consider guarding with a type check (e.g., only call hasKey when .Values.runtime is a map) so the chart fails deterministically with your clearer message.

{{- if hasKey .Values.runtime "cache" }}
{{- fail "values key `runtime.cache` has been renamed to `runtime.cacheruntime`, please update your values file or --set flags" }}
{{- end }}

charts/fluid/fluid/templates/controller/cacheruntime_controller.yaml:27

• This annotation is currently driven only by replicas > 1, independent of runtime.cacheruntime.enabled. If a user sets replicas: 3 while enabled: false, the Deployment still renders replicas: 0 but retains an annotation suggesting multiple replicas, which is inconsistent and can confuse debugging/operations. Consider gating this condition on enabled as well (or otherwise deriving the annotation from the effective replica count).

      {{ if gt (.Values.runtime.cacheruntime.replicas | int) 1 -}}
        controller.runtime.fluid.io/replicas: {{ .Values.runtime.cacheruntime.replicas | quote }}