Migrate ScatterPlot to PureScript; fix xAxis tickSizeOuter#1524
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…, zero-before-interaction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…remains in JS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…near Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Axis/numericYAxis Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…/numericYAxis Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merge App.Util (classes) into existing App.Util import; remove unused UIHelpers/uiHelpers from App.View.Util and unused Select. Surfaced by CI's prod build under --strict. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rolyp
commented
Apr 14, 2026
| , "y" ⟼ height + 25 | ||
| , "style" ↦ "text-anchor: end; font-size: 10px" | ||
| ] | ||
| >>= setText (contents lx) |
Collaborator
Author
There was a problem hiding this comment.
labels.x might be clearer here
| , "y" ⟼ negate margin.left + 20 | ||
| , "style" ↦ "text-anchor: end; font-size: 10px" | ||
| ] | ||
| >>= setText (contents ly) |
| , classes [ "center" ] | ||
| ] | ||
| rootElement <- svg # create G | ||
| [ "transform" ↦ ("translate(" <> show margin.left <> ", " <> show margin.top <> ")") ] |
Collaborator
Author
There was a problem hiding this comment.
Do we have helpers anywhere that construct translate specifications? (Not suggesting we necessarily need one, but let's if there is something already, or whether the pattern recurs elsewhere.)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Addressed in aaee5ae:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScatterPlot.setSelectionandcreateElementto PureScript, deletingScatterPlot.jsentirelynumericXAxis/numericYAxisforeigners to sharedD3module for auto-tick numeric axesD3.scaleLinearxAxismissingtickSizeOuter(0), making all four axis functions consistentTest plan
energy-scatter: 10 points render, default radius, hover/click selection, cross-selection to data panerenewables-linked: bar chart x-axis outer tick caps removed (visual)🤖 Generated with Claude Code