Skip to content

Hover-hint on data pane toggle when there is pending selection (#1013)#1527

Closed
rolyp wants to merge 1 commit into
fluid-0.13from
1013-toggle-hover-hint
Closed

Hover-hint on data pane toggle when there is pending selection (#1013)#1527
rolyp wants to merge 1 commit into
fluid-0.13from
1013-toggle-hover-hint

Conversation

@rolyp
Copy link
Copy Markdown
Collaborator

@rolyp rolyp commented Apr 14, 2026

Summary

  • When the data pane is collapsed and an output selection has propagated persistent highlighting into (hidden) input cells, the toggle button adopts its hover colour to signal "there is data to explore"
  • Pure-CSS `:has()` rule in `DataPane.svelte` — no reactive plumbing needed between Fluid's runtime and the Svelte host

Closes #1013.

Test plan

  • New puppeteer test case in energy-scatter: verify toggle colour is `rgb(204, 204, 204)` on load, then `rgb(153, 153, 153)` after clicking a scatter point (with pane still hidden)
  • Existing tests still pass on Chrome + Firefox
  • Manual: visit `/energy-scatter`, click a scatter point, confirm toggle button icon visibly darkens

🤖 Generated with Claude Code

Pure-CSS :has() rule: when the grid is collapsed and the (hidden) data
pane contains a .selected-primary-persistent element, the toggle button
adopts the same colour as its :hover state. Signals "there is data to
explore" without any reactive plumbing between Fluid's runtime and
the host Svelte components.

Closes #1013.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rolyp
Copy link
Copy Markdown
Collaborator Author

rolyp commented Apr 14, 2026

Closing without merge — the implementation faithfully executes the issue's proposal (reusing :hover styling) but that's the wrong mechanism. See issue thread for rework plan.

@rolyp rolyp closed this Apr 14, 2026
@rolyp rolyp deleted the 1013-toggle-hover-hint branch April 14, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant