[Triage bot] Do not report private things to Discord #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
commented
Apr 2, 2025
| @@ -815,7 +815,8 @@ class Engine { | |||
| } | |||
|
|
|||
| Future<void> _updateDiscordFromWebhook(String event, dynamic payload) async { | |||
| if (GitHubSettings.knownBots.contains(payload.sender.login.toString())) { | |||
| if (GitHubSettings.knownBots.contains(payload.sender.login.toString()) | |||
There was a problem hiding this comment.
Is this around about the change you made in your copy @Hixie ?
There was a problem hiding this comment.
I ended up doing:
if (!payload.repository.isNull && payload.repository.private.isBoolean && payload.repository.private.toBoolean()) {
return;
}...with suitable changes to json.dart (adding isNull, isBoolean). The isBoolean is probably not necessary. The isNull is, because GitHub's API doesn't always send a repository key. HTH.
There was a problem hiding this comment.
Ok, thanks! 🙏 I will circle back on this next week after Cloud Next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the code that is the deployed triage bot, @Hixie says it has diverged from the one he has running.
If we do end up deploying our own instance of this triage bot, which also posts to Discord, we don't want to fall into the same issue we had the other day.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.