Skip to content

[CQ] API: migrate from to-be-removed AnActionListener APIs #8076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 17, 2025

Migrate to safe AnActionListener APIs.

This migration has been attempted before but was reverted as possibly causing a hot reload regression (#6996).

I've confirmed that hot reload works (Mac OS Meerkat) but have preserved the note in case anything odd happens.

See: #7718

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq pq requested a review from jwren April 17, 2025 21:57
@jwren
Copy link
Member

jwren commented Apr 17, 2025

Giving approval, but do land this with caution. Do build it and try the zip to validate that we don't do a push which breaks it.

Also, 🎉

@pq pq merged commit 1ad4afa into flutter:master Apr 17, 2025
7 checks passed
@pq pq deleted the cq_AnActionListener_API branch April 17, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants