Skip to content

[perf] ensure mock auto-closeable is closed #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 29, 2025

MockitoAnnotations.openMocks returns an auto-closeable that a try-with-resources statement ensures will get closed.

Follow-up from #8111 and related to #8110.

(Also some opportunistic unused import cleanup.)


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from jwren and elliette April 29, 2025 23:44
@pq pq merged commit 8542457 into flutter:master Apr 30, 2025
7 checks passed
@pq pq deleted the perf_FlutterViewTest_autoCloseable branch April 30, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants