Skip to content

[CQ] remove (dead) FlutterStudioInitializer #8212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented May 21, 2025

FlutterStudioInitializer exists to perform a check at startup to ensure AS is current enough for... something...
I can't recall the motivation for this extra check (despite having reviewed it in #1346 😬) but it was 8 years ago!

Needless to say, removing it is surely safe:

  1. the com.intellij.androidStudioInitializer extension point seems to have gone away, and even if it hadn't,
  2. we're surely past the window where there are any version out there that are too early for the version check

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from jwren May 21, 2025 21:17
@pq
Copy link
Contributor Author

pq commented May 22, 2025

Thanks!

@pq pq merged commit 0fdf15c into flutter:master May 22, 2025
7 checks passed
@pq pq deleted the cq_androidStudioInitializer branch May 22, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants