[cupertino_ui] Use super parameters in more places - #12459
Conversation
This is work towards dart-lang/sdk#59226 The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the constructors of the _Segment and _SegmentSeparator classes in sliding_segmented_control.dart to use super-initializer parameters for the key property. There are no review comments, and I have no feedback to provide.
Piinks
left a comment
There was a problem hiding this comment.
Thanks @srawlins! I think these will be safe to land in flutter/flutter as well so that dart-lang/sdk#47839 is not blocked from landing there. :)
Let me know if I can help with that.
For the PRs in cupertino_ui and material_ui, they will need a pending changelog file. See https://github.com/flutter/packages/pull/12381/files for an example. We have a new batch release process that pulls them all together into one changelog entry before a release.
There is a template in pending_changelogs/
This is work towards dart-lang/sdk#59226
The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.
Pre-Review Checklist
[shared_preferences]///).Test exempt, as this code is covered by existing static and runtime checks.