Skip to content

[cupertino_ui] Use super parameters in more places - #12459

Open
srawlins wants to merge 1 commit into
flutter:mainfrom
srawlins:use-super-cup
Open

[cupertino_ui] Use super parameters in more places#12459
srawlins wants to merge 1 commit into
flutter:mainfrom
srawlins:use-super-cup

Conversation

@srawlins

Copy link
Copy Markdown
Contributor

This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.

Pre-Review Checklist

Test exempt, as this code is covered by existing static and runtime checks.

This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously
report these cases. But they will be reported soon.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 13, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the constructors of the _Segment and _SegmentSeparator classes in sliding_segmented_control.dart to use super-initializer parameters for the key property. There are no review comments, and I have no feedback to provide.

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srawlins! I think these will be safe to land in flutter/flutter as well so that dart-lang/sdk#47839 is not blocked from landing there. :)
Let me know if I can help with that.

For the PRs in cupertino_ui and material_ui, they will need a pending changelog file. See https://github.com/flutter/packages/pull/12381/files for an example. We have a new batch release process that pulls them all together into one changelog entry before a release.
There is a template in pending_changelogs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants