Skip to content

[cupertino_ui] Deprecate CupertinoSegmentedControl - #12766

Open
ValentinVignal wants to merge 3 commits into
flutter:mainfrom
ValentinVignal:cupertino-ui/Deprecate-cupertino-segmented-control
Open

[cupertino_ui] Deprecate CupertinoSegmentedControl#12766
ValentinVignal wants to merge 3 commits into
flutter:mainfrom
ValentinVignal:cupertino-ui/Deprecate-cupertino-segmented-control

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Fixes flutter/flutter#152910

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 5, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added p: cupertino_ui triage-design Should be looked at in design triage labels Sep 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates CupertinoSegmentedControl in favor of CupertinoSlidingSegmentedControl and adds a pending changelog entry. The feedback indicates that the @Deprecated annotation on the constructor is redundant and improperly indented, as deprecating the class itself is sufficient.

Comment on lines 114 to 115
@Deprecated('Use CupertinoSlidingSegmentedControl instead.')
CupertinoSegmentedControl({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Deprecating the class CupertinoSegmentedControl itself (on line 97) is sufficient to deprecate all of its constructors and usages. Adding a separate @Deprecated annotation on the constructor is redundant. Additionally, the annotation on line 114 is missing the 2-space indentation to match the constructor.

We should remove this redundant annotation.

  CupertinoSegmentedControl({

@ValentinVignal

Copy link
Copy Markdown
Contributor Author

I think this PR is test-exempted: "refactors with no semantic change"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: cupertino_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider deprecating CupertinoSegmentedControl

1 participant