Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

kaiquegazola
Copy link

@kaiquegazola kaiquegazola commented Jan 22, 2025

Adds StoreKit2 support for:

  • Win Back Offers (requires Xcode 16 or later)
    • New checkWinBackOfferEligibility method for eligibility checks
  • Promotional Offers
  • Fixes introductory pricing handling in promotional offers list
  • Fixes appAccountToken handling for StoreKit2 purchases

Fixes:
flutter/flutter#161393
flutter/flutter#160826

Pre-launch Checklist

@LouiseHsu
Copy link
Contributor

Hey just letting you know Ive looked at your PR, and it looks really good! I've checked out your branch and it seems to work well locally. However our tests are failing to compile because currently they're running on ios 17.0. I'm taking a look to see if theres a way around this, but if you want to try building your branch on Xcode 15 or lower that would be really helpful too!

@kaiquegazola
Copy link
Author

Thanks for for testing it locally

It seems we’re currently blocked by flutter/flutter#148870. Also, I think we should add a CHANGELOG warning regarding this Xcode requirement.

Maybe an #if compiler directive could help here, but I haven’t tested it yet, so I’m not sure if it actually works. Let me know what you think

…se-storekit2-win-back-offers

# Conflicts:
#	packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
@kaiquegazola kaiquegazola marked this pull request as draft January 30, 2025 19:37
@kaiquegazola kaiquegazola marked this pull request as ready for review January 31, 2025 03:14
@kaiquegazola
Copy link
Author

Hi @LouiseHsu, when you have a moment, could you please take a look at this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants