Skip to content

[rfw] Update tests to no longer depend on a Container pumped via testWidgets. #9063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ksokolovskyi
Copy link
Contributor

This PR updates rfw package tests to no longer depend on a Container pumped via testWidgets to unblock further work on flutter/flutter#163419

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@ksokolovskyi ksokolovskyi requested a review from Hixie as a code owner April 12, 2025 12:14
@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Apr 12, 2025
@ksokolovskyi
Copy link
Contributor Author

Hi @Hixie, could you please take a look at this PR when you have time? Thanks!

@@ -1,3 +1,7 @@
## 1.0.32

* Updates tests to no longer depend on a `Container` pumped via `testWidgets`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the test/ directory don't need changelog and version changes, so these should be reverted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I've reverted this change in the latest commit.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented May 8, 2025

A change that broke this would break tons of other tests across the community. I think we should take this as a sign that the underlying change is too dangerous to make, not as a sign that RFW's tests need changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants