-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[rfw] Update tests to no longer depend on a Container
pumped via testWidgets
.
#9063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[rfw] Update tests to no longer depend on a Container
pumped via testWidgets
.
#9063
Conversation
Hi @Hixie, could you please take a look at this PR when you have time? Thanks! |
packages/rfw/CHANGELOG.md
Outdated
@@ -1,3 +1,7 @@ | |||
## 1.0.32 | |||
|
|||
* Updates tests to no longer depend on a `Container` pumped via `testWidgets`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in the test/
directory don't need changelog and version changes, so these should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I've reverted this change in the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A change that broke this would break tons of other tests across the community. I think we should take this as a sign that the underlying change is too dangerous to make, not as a sign that RFW's tests need changing. |
This PR updates
rfw
package tests to no longer depend on aContainer
pumped viatestWidgets
to unblock further work on flutter/flutter#163419Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3