-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: Expose setUseWideViewPort on Android (#106999) #9151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This may break some people; see flutter/flutter#93125 for example. |
Thank you for the intels.
That's true, what exactly should be the next steps? I also tried to reproduce your linked issue, but couldn't as the linked site was reworked and doesn't show this problem any more.
|
I think these are good arguments for switching the default back. And clients will have the escape hatch of the new setting if they really need the other behavior. Thanks for the analysis! Since the initial change wasn't a major version change, and as you point out this is likely not going to affect most clients, we don't need to do a major version change to switch it back IMO. |
Thank you for the fast reply. Should I leave the viewport meta example in the example project? Or is it also desired to be adapted in the |
The option to set whether the webview should use the wide viewport should be available.
Also the default is changed to false, because this is the expected behavior on Android devices:
https://developer.android.com/develop/ui/views/layout/webapps/targeting
On iOS also the default behavior is to NOT use wide viewport, so this is aligned.
This also partically solves flutter/flutter#106999, as then the correct height is returned from
document.documentElement.scrollHeight;
property.If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.