-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[vector_graphics]Add Null Check for Image Retrieval in listener.dart's onDrawImage Function #9211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…error messages, and enhance the robustness and maintainability of the code.
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
This change is exempt from additional testing as it does not alter any existing functionality. |
Thanks for the submission! In the future, please do not delete things from the checklist that is in the PR template; they are there for a reason. This PR is missing required elements described in the checklist (I’ve restored the missing parts to the PR description), which need to be addressed before it moves forward with review. I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.
Could you quote the part of the linked documentation about the test requirement that led you to believe that bugfixes are exempt from testing? |
…ages. - Ensure validity checks are performed before accessing images. - Provide informative error messages for better debugging. - Improve code robustness and maintainability.
…eId in onDrawImage.
@stuartmorgan-g |
This PR adds error handling for #168364
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1].CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1].///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.