Skip to content

add horizontal scrollbar support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GAM3RG33K
Copy link

add horizontal scrollbar support in the library and a demo tab in the example app.

Screenshots attached for details
Screenshot_1569633376
Screenshot_1569633370

 - add horizontal scrollbar support
 - add horizontal scrollbar tab in example app
@GAM3RG33K
Copy link
Author

@marica27 This is my first pull request, so can you just check it out and let me know?
Thanks in advance.

@rayliverified
Copy link

What is the status on the PR? I would like to use a draggable horizontal scrollbar in my project.

@emvaized
Copy link

By the way, you forgot to modify SlideTransition, so that when child is horizontal, scrollbar pulp should go down on dissapearing, and not to the side.

To fix this you should make SlideFadeTransition accept isVertical parameter as well, and inside build method:

...
position: Tween(
          begin: Offset(isVertical ? 0.3 : 0.0, isVertical ? 0.0 : 0.3),
...

@GAM3RG33K
Copy link
Author

@emvaized That's right. I don't know how it got out of my attention. I will fix it soon. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants