Skip to content

fix: reconcile service trafficDistribution updates #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
immanuwell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reconcile service trafficDistribution updates #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/router/kubernetes_default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,11 @@ func (c *KubernetesDefaultRouter) reconcileService(canary *flaggerv1.Canary, nam

portsDiff := cmp.Diff(svcSpec.Ports, svc.Spec.Ports, cmpopts.SortSlices(sortPorts))
selectorsDiff := cmp.Diff(svcSpec.Selector, svc.Spec.Selector)
if portsDiff != "" || selectorsDiff != "" {
trafficDistributionDiff := cmp.Diff(svcSpec.TrafficDistribution, svc.Spec.TrafficDistribution)
if portsDiff != "" || selectorsDiff != "" || trafficDistributionDiff != "" {
svcClone.Spec.Ports = svcSpec.Ports
svcClone.Spec.Selector = svcSpec.Selector
svcClone.Spec.TrafficDistribution = svcSpec.TrafficDistribution
updateService = true
}

Expand Down
45 changes: 45 additions & 0 deletions pkg/router/kubernetes_default_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,51 @@ func TestServiceRouter_TrafficDistribution(t *testing.T) {
assert.Equal(t, trafficDistribution, *apexSvc.Spec.TrafficDistribution)
}

func TestServiceRouter_UpdateTrafficDistribution(t *testing.T) {
mocks := newFixture(nil)
router := &KubernetesDefaultRouter{
kubeClient: mocks.kubeClient,
flaggerClient: mocks.flaggerClient,
logger: mocks.logger,
}

err := router.Initialize(mocks.canary)
require.NoError(t, err)

err = router.Reconcile(mocks.canary)
require.NoError(t, err)

canary, err := mocks.flaggerClient.FlaggerV1beta1().Canaries("default").Get(context.TODO(), "podinfo", metav1.GetOptions{})
require.NoError(t, err)

canaryClone := canary.DeepCopy()
trafficDistribution := "PreferClose"
canaryClone.Spec.Service.TrafficDistribution = trafficDistribution

updatedCanary, err := mocks.flaggerClient.FlaggerV1beta1().Canaries("default").Update(context.TODO(), canaryClone, metav1.UpdateOptions{})
require.NoError(t, err)

err = router.Initialize(updatedCanary)
require.NoError(t, err)
err = router.Reconcile(updatedCanary)
require.NoError(t, err)

canarySvc, err := mocks.kubeClient.CoreV1().Services("default").Get(context.TODO(), "podinfo-canary", metav1.GetOptions{})
require.NoError(t, err)
require.NotNil(t, canarySvc.Spec.TrafficDistribution)
assert.Equal(t, trafficDistribution, *canarySvc.Spec.TrafficDistribution)

primarySvc, err := mocks.kubeClient.CoreV1().Services("default").Get(context.TODO(), "podinfo-primary", metav1.GetOptions{})
require.NoError(t, err)
require.NotNil(t, primarySvc.Spec.TrafficDistribution)
assert.Equal(t, trafficDistribution, *primarySvc.Spec.TrafficDistribution)

apexSvc, err := mocks.kubeClient.CoreV1().Services("default").Get(context.TODO(), "podinfo", metav1.GetOptions{})
require.NoError(t, err)
require.NotNil(t, apexSvc.Spec.TrafficDistribution)
assert.Equal(t, trafficDistribution, *apexSvc.Spec.TrafficDistribution)
}

func TestServiceRouter_Update(t *testing.T) {
mocks := newFixture(nil)
router := &KubernetesDefaultRouter{
Expand Down