Workaround for poppler_rs #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To workaround around https://gitlab.gnome.org/World/Rust/poppler-rs/-/issues/1 whilst the issue is not acknowledged/fixed. Workaround for flxzt#1228
|
I am uncertain when this will be fixed upstream. Do you think we should merge this dependency update to fix the windows build? |
|
I should add the revision to the cargo.toml file (and clean up the lock file) in that case before a potential merge. Maybe it's better to merge now (makes a new release possible on windows, makes building easier for contributors) as we don't have a timeframe. I was hopeful we'd see some activity tied with the usual annual linux releases (new distribution versions, gtk etc...) but I've not seen much for now. |
|
I locked the git revision (and the |
|
alright, looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst waiting on https://gitlab.gnome.org/World/Rust/poppler-rs/-/issues/1 to be fixed, fixes #1228.
I've changed the github repo to highlight the changes with the current poppler_rs: Doublonmousse/poppler-patch@3acaa4e
I'll leave this as a draft for now, and will change to a dependency bump once poppler is updated with the fix.