Suppress formattable hides the global definition
warning
#4378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warning that is received on MSVC v17.3.6 with the compiler flag
/W4
. The warning is as follows:declaration of 'formattable' hides global declaration
. It appears on every file wherefmt/core.h
is included.I renamed it tois_formattable
but this can be changed since it seems likeis_formattable
is used in other places as well.EDIT: After looking through other PRs, namely #4377, I thought it may be preferred (and less breaking) to suppress the warnings via macros rather than change existing code.