Unreachable code & constexpr constructor bigint() #4388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR but fixing all possible warnings especially on compilers we don't have access to is a non-goal. I recommend suppressing the warning on your side instead. |
dinomight
reviewed
Mar 17, 2025
| @@ -542,10 +551,11 @@ template <typename Char> class basic_string_view { | |||
| size_ = __builtin_strlen(detail::narrow(s)); | |||
| return; | |||
| } | |||
| #endif | |||
| #else | |||
There was a problem hiding this comment.
This is likely not a good idea because you would completely skip the strlen if Char is not a char, say a wchar_t. The better answer would involve some kind of if constexpr setup so that you have a fallback for wide chars.
There was a problem hiding this comment.
Yeah I noticed issues with the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proprietary, strict compiler complains about the following:
Unreachable code: certain branches in
fmt/base.hare unreachable.Fix: Add branches
Constexpr constructor constructing non-constexpr member:
Fix: make constexpr constructor default.