[Do not Merge] CI Test #1421
Open
[Do not Merge] CI Test #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added missing includes of dependent internal headers * Cleaned up amalgamation files to only include the public facing high-level headers
Same as in all other locations
We need to take into consideration that exporting a namespace (as a named module) is kind of greedy in the sense that also nested namespaces are exported.
When importing sqlite_orm as a named module, sqlite3 symbols are not exported.
The `cxx_universal.h` exists to provide symbols that sqlite_orm depends on everywhere. It is easy to forget to include it. And more importantly there are decision macros used that need to be defined before certain files anyway, which is the reason that `cxx_universal.h` gets included by the files used for amalgamation. Hence I decided to not include it anymore.
gcc until v13.3 had the bad habit to deduce a constant template parameter as const; remove it
C++17 round 2: constexpr if statements
The following C++ language features are now a requirement: * Exception specifications as part of the type system. * Fold expressions. * constexpr lambda expressions. * Initialization of aggregate classes with base classes.
…te-vfs Added support for choosing the SQLite VFS and open mode flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.