Skip to content

Fix extra line breaks between link definitions in vscode plugin - #1687

Merged
riccardoferretti merged 3 commits into
foambubble:mainfrom
Strepto:fix/vscode-extra-linebreak-between-definitions
Jul 19, 2026
Merged

Fix extra line breaks between link definitions in vscode plugin#1687
riccardoferretti merged 3 commits into
foambubble:mainfrom
Strepto:fix/vscode-extra-linebreak-between-definitions

Conversation

@Strepto

@Strepto Strepto commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Remove unnecessary line breaks when updating wikilink definitions and add comments for clarity.

AI assisted, human reviewed. Feel free to close if the fix is in the wrong place, but I feel this works well.

@riccardoferretti

Copy link
Copy Markdown
Collaborator

Thanks for this - the fix itself is correct.

Before I merge: the second test, orders existing definitions by wikilink occurrence when configured, is failing on the branch and asserts behavior that doesn't exist.
Could you drop that test? The first one is what actually exercises the fix and it passes.

Once that's done I will be happy to merge, thanks!

@Strepto

Strepto commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Ah. I thought I rolled the sorting back before I committed but I left the test. Sorry. I looked into sorting all the references, but it may add more churn in git conflicts etc, so I dropped it.

@riccardoferretti
riccardoferretti merged commit 97549f1 into foambubble:main Jul 19, 2026
4 checks passed
@Strepto
Strepto deleted the fix/vscode-extra-linebreak-between-definitions branch July 19, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants