Fix extra line breaks between link definitions in vscode plugin - #1687
Merged
riccardoferretti merged 3 commits intoJul 19, 2026
Merged
Conversation
Collaborator
|
Thanks for this - the fix itself is correct. Before I merge: the second test, orders existing definitions by wikilink occurrence when configured, is failing on the branch and asserts behavior that doesn't exist. Once that's done I will be happy to merge, thanks! |
Contributor
Author
|
Ah. I thought I rolled the sorting back before I committed but I left the test. Sorry. I looked into sorting all the references, but it may add more churn in git conflicts etc, so I dropped it. |
riccardoferretti
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary line breaks when updating wikilink definitions and add comments for clarity.
AI assisted, human reviewed. Feel free to close if the fix is in the wrong place, but I feel this works well.