Skip to content

Conversation

@SentientCoffee
Copy link
Contributor

  • Reworked retroactive proc highlighting (based on Odin's proc highlighting)
    • Added exceptions so that most instances of Poly_Type(T) don't get mistakenly highlighted as procs
  • Added initializer_of as a keyword
  • Added Type type

@focus-editor
Copy link
Owner

Sorry, I'm not sure I want to merge this change. I've already rejected a similar change which tried to improve type highlighting - #106 . The reason is that there's a line we must draw when doing this type of highlighting, after which we don't want to spend any effort improving the highlighting, because it gets progressively more expensive and still doesn't fix everything.

Given how often we use this tokenizer I don't want to make it slower just to fix some Type(T) instances, which TBH are fine to be highlighted as procs because they could be thought as ones.

I would merge the rest of the changes if you modified the PR

@SentientCoffee
Copy link
Contributor Author

Understandable, I've reverted the major highlighting change.

@SentientCoffee SentientCoffee changed the title Improve Jai syntax highlighting Add initializer_of keyword and Type type for Jai Jan 1, 2024
@focus-editor focus-editor merged commit 8e931f5 into focus-editor:main Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants