Add initializer_of keyword and Type type for Jai#267
Merged
focus-editor merged 1 commit intofocus-editor:mainfrom Jan 1, 2024
Merged
Add initializer_of keyword and Type type for Jai#267focus-editor merged 1 commit intofocus-editor:mainfrom
initializer_of keyword and Type type for Jai#267focus-editor merged 1 commit intofocus-editor:mainfrom
Conversation
Owner
|
Sorry, I'm not sure I want to merge this change. I've already rejected a similar change which tried to improve type highlighting - #106 . The reason is that there's a line we must draw when doing this type of highlighting, after which we don't want to spend any effort improving the highlighting, because it gets progressively more expensive and still doesn't fix everything. Given how often we use this tokenizer I don't want to make it slower just to fix some Type(T) instances, which TBH are fine to be highlighted as procs because they could be thought as ones. I would merge the rest of the changes if you modified the PR |
Contributor
Author
|
Understandable, I've reverted the major highlighting change. |
initializer_of keyword and Type type for Jai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poly_Type(T)don't get mistakenly highlighted as procsinitializer_ofas a keywordTypetype