-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data lake store account service added #296
base: master
Are you sure you want to change the base?
Conversation
Summary: The Data Lake Store account feature has been developed. Test Plan: Integration Tests and Unit Test are passed Reviewers: bilal.naeem Subscribers: omair.sajid Differential Revision: http://phabricator.confiz.com/D10349
|
||
def data_lake_store_account(service) | ||
Fog::DataLakeStore::AzureRM::DataLakeStoreAccount.new( | ||
name: 'fogtestdls', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the start of the previous line.
account_type: 'Premium_LRS', | ||
disk_size_gb: 1023, | ||
creation_data: { | ||
create_option: 'Empty' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
create_option: 'Empty' | ||
}, | ||
service: service | ||
name: 'managed-disk', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the start of the previous line.
location: 'westus', | ||
type: 'Microsoft.RecoveryServices/vaults', | ||
sku: { | ||
name: 'standard' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
name: 'standard' | ||
}, | ||
service: service | ||
name: 'fog-test-vault', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the start of the previous line.
name: 'firstgateway' | ||
}, | ||
virtual_network_gateway2: { | ||
name: 'secondgateway' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
}, | ||
resource_group: 'learn_fog', | ||
virtual_network_gateway1: { | ||
name: 'firstgateway' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
name: 'testNetworkGateway', | ||
location: 'eastus', | ||
tags: { | ||
key1: 'value1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
routing_weight: 2, | ||
shared_key: 'shared_key', | ||
service: service | ||
name: 'testNetworkGateway', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the start of the previous line.
authorization_use_status: 'Available', | ||
authorization_name: 'circuit-auth-name', | ||
service: service | ||
name: 'UniqueAuthorizationName', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the start of the previous line.
:name, | ||
:id, | ||
:resource_group | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add all the other attributes that are present in the DataLakeStoreAccount
model
class Mock | ||
def create_data_lake_store_account(*) | ||
{ | ||
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
class Mock | ||
def update_data_lake_store_account(*) | ||
{ | ||
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
account | ||
end | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra blank line detected.
class Mock | ||
def get_data_lake_store_account(*) | ||
{ | ||
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
'resource_group' => 'resource_group' | ||
}, | ||
{ | ||
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
def list_data_lake_store_accounts | ||
[ | ||
{ | ||
'id' => '/subscriptions/########-####-####-####-############/resourceGroups/resource_group/providers/Microsoft.DataLakeStore/accounts/name', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
class Mock | ||
def list_data_lake_store_accounts | ||
[ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.
start_ip: '10.10.10.10', | ||
end_ip: '10.10.10.10', | ||
service: service | ||
name: 'fog-test-firewall-rule-name', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the start of the previous line.
administrator_login: 'test-admin@3', | ||
administrator_login_password: 'pass@swe', | ||
service: service | ||
name: 'fog-test-zone.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the start of the previous line.
@bilal-naeem-confiz is this still current since it merges from an unknown repository? |
@aheumaier the reason we have this PR open is because it does not work with the Azure SDK version that we currently have in fog-azure-rm. We are using Azure SDK v0.9.0 whereas IIRC, this feature will work with Azure SDK v0.11.0 or greater. |
Data lake store account service has been added to fog azure-rm