Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/add possibility to detach multiple managed disks #400

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance/add possibility to detach multiple managed disks #400

wants to merge 2 commits into from

Conversation

KevinLoiseau
Copy link
Contributor

@KevinLoiseau KevinLoiseau commented Oct 5, 2018 •
edited
Loading

Hi !

In this little PR I enable the possibility to detach more than one managed disk on the same request.

Thanks in advance for your time

houndci-bot
houndci-bot reviewed Oct 5, 2018
View reviewed changes
test/requests/compute/test_detach_data_disk_from_vm.rb Outdated Show resolved Hide resolved
test/models/compute/test_server.rb Outdated Show resolved Hide resolved
test/models/compute/test_server.rb Outdated Show resolved Hide resolved
@KevinLoiseau KevinLoiseau force-pushed the enhance/add_possibility_to_detach_multiple_managed_disks branch from fe29c59 to 20f42e7 Compare October 5, 2018 10:06
@KevinLoiseau KevinLoiseau force-pushed the enhance/add_possibility_to_detach_multiple_managed_disks branch from 20f42e7 to fd4b06a Compare October 15, 2018 09:54
@KevinLoiseau KevinLoiseau force-pushed the enhance/add_possibility_to_detach_multiple_managed_disks branch from fd4b06a to 50c9ee6 Compare October 15, 2018 10:28
@maham-nazir-confiz
Copy link
Contributor

Hello @KevinLoiseau
I will be reviewing and testing this PR. I will merge it if it passes all checks. It might take me some time. Thank you for your patience.

@maham-nazir-confiz
Copy link
Contributor

@KevinLoiseau
The PR looks fine. Please make the following changes

  • Update the server.rb integration test to test out this scenario as well.

Regards

@maham-nazir-confiz
Copy link
Contributor

@KevinLoiseau

Please update the integration test server.rb to test this scenario as well.

Regards,
Maham Nazir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinLoiseau @maham-nazir-confiz @houndci-bot