-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URLs to use v3 when only v2 endpoint is listed in the catalog #513
base: master
Are you sure you want to change the base?
Conversation
Build succeeded.
|
Build failed.
|
Build succeeded.
|
It covers the cases where we can authenticate with keystone v3 but the endpoint returned in the catalog is v2 see fog#492
Build succeeded.
|
tested on an OpenStack not exposing a endpoint for v3 and this fix work fine. |
Just have a little problem with that, it's missing tests implementation of the corrected bug. I can believe @pdion891 on word but it seems a little risky for the others. Implemented tests are passing anyway. |
A test would certainly be good, @achevalet please let us know if you plan to add one. |
For sure I've only validated the use case that was valid on my side where the /v3 is not exposed. |
Quite busy, I would be grateful if someone can contribute here |
It covers the cases where we can authenticate with keystone v3 but the endpoint returned in the catalog is v2
see #492
You guys can probably do something much cleaner as I have poor ruby skills, but it fixes my issue and the tests passed so I'm proposing.. :-)