Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support for ruby 3 / 3.1 #527

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

chaadow
Copy link

@chaadow chaadow commented Oct 8, 2022

This basically replaces all URI.encode occurences with CGI.escape

As the maintainer of activestorage-openstack. this has made my test suite pass both on ruby 3.0 and 3.1 so the change should be enough for the storage component

It would be much appreciated if a release is made with this PR merged 🙏🏼

Fixes #522

@chaadow chaadow changed the title Add partial support for ruby 3 Add partial support for ruby 3 / 3.1 Oct 8, 2022
@chaadow chaadow mentioned this pull request Oct 8, 2022
@maciejpankanin
Copy link

I don't think CGI.escape is a good choice here since we need URL escaping. See https://stackoverflow.com/a/13059657/7998769.

I think using addressable gem would be safer.

@geemus
Copy link
Member

geemus commented May 13, 2024

I think the bigger question is whether any of these should keep / or not (ie it looks like some names might include this, which probably shouldn't be escaped but CGI would escape it). Can anyone speak more authoritatively on whether we should be concerned about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 3.0 support
3 participants