Explicitly list files and dirs included in gemspec (test_)files #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dosas can you rebase this on the 2 pr's of yours I just merged, to see if the tests go green? |
Done |
|
@chris1984 I would like to add this approach to all fog-* repos, what do you think? |
Yeah I thnk this is a great idea, thanks for helping out here. I don't have merge access on the others, but I would think it would be accepted. |
chris1984
approved these changes
May 2, 2024
|
There is still a typo |
with the catch all approach there were a lot of files included that do not need to be in the gem. I.e. Jenkinsfile all dot files and dirs related to CI configuration and rubocop linting ... This causes problems whe i.e. building rpm packages where all of these files need to be explicitly excluded.
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the catch all approach there were a lot of files included that do not need to be in the gem. I.e. Jenkinsfile, all dot files and dirs related to CI configuration, and rubocop linting ...
This causes problems when i.e. building rpm packages where all of these files need to be explicitly excluded: see https://github.com/theforeman/foreman-packaging/blob/rpm/develop/packages/foreman/rubygem-fog-vsphere/rubygem-fog-vsphere.spec#L50