MODROLESKC-332: Cleanup capabilities in roles upon application revocation #220
Open
OleksiiKuzminov wants to merge 1 commit intomasterfrom
Open
MODROLESKC-332: Cleanup capabilities in roles upon application revocation #220OleksiiKuzminov wants to merge 1 commit intomasterfrom
OleksiiKuzminov wants to merge 1 commit intomasterfrom
Conversation
…tion (#217) * feat: enable entitledOnly for _self permissions lookup * test: align _self stubs with entitledOnly query parameter * feat: update UserPermissionsClient to include entitledOnly parameter in permissions lookup * refactor: simplify collection of service points in UserService (cherry picked from commit d78c930)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Enable the
entitledOnlyquery parameter on the_selfpermissions endpoint, so only permissions from entitled modules are returned. This aligns_selfwith the filtering behavior introduced for the main permissions lookup in MODUSERSKC-138.Approach
entitledOnlyas an optional@RequestParamonUserPermissionsClient.getPermissionsUser()(Feign client interface).entitledOnly=trueinUserService.fetchPermissionUser()(the_selfcode path). TheresolvePermissionspath continues to passnull, preserving existing behavior.urlmatching tourlPath+queryParametersto handle the new parameter in integration tests.verify()calls to assert the exact arguments forwarded to the permissions client.Pre-Review Checklist