Skip to content

MODROLESKC-332: Cleanup capabilities in roles upon application revocation #220

Open
OleksiiKuzminov wants to merge 1 commit intomasterfrom
MODROLESKC-332
Open

MODROLESKC-332: Cleanup capabilities in roles upon application revocation #220
OleksiiKuzminov wants to merge 1 commit intomasterfrom
MODROLESKC-332

Conversation

@OleksiiKuzminov
Copy link
Copy Markdown
Collaborator

Purpose

Enable the entitledOnly query parameter on the _self permissions endpoint, so only permissions from entitled modules are returned. This aligns _self with the filtering behavior introduced for the main permissions lookup in MODUSERSKC-138.

Approach

  • Added entitledOnly as an optional @RequestParam on UserPermissionsClient.getPermissionsUser() (Feign client interface).
  • Passed entitledOnly=true in UserService.fetchPermissionUser() (the _self code path). The resolvePermissions path continues to pass null, preserving existing behavior.
  • Updated WireMock stubs from exact url matching to urlPath + queryParameters to handle the new parameter in integration tests.
  • Tightened unit test verify() calls to assert the exact arguments forwarded to the permissions client.

Pre-Review Checklist

  • Self-reviewed Code — Reviewed code for issues, unnecessary parts, and overall quality.
  • Change Notes — NEWS.md updated with clear description and issue key.
  • Testing — Confirmed changes were tested locally or on dev environment.
  • Breaking Changes — Handled all required actions if changes affect API, DB, or interface versions.
    • API/schema changes
    • Interface version updates
    • DB schema changes / migration scripts
  • New Properties / Environment Variables — Updated README.md if new configs were added.
  • Environment Recreation Test (if needed) — Verified that environment can be recreated successfully.

…tion (#217)

* feat: enable entitledOnly for _self permissions lookup

* test: align _self stubs with entitledOnly query parameter

* feat: update UserPermissionsClient to include entitledOnly parameter in permissions lookup

* refactor: simplify collection of service points in UserService

(cherry picked from commit d78c930)
@OleksiiKuzminov OleksiiKuzminov self-assigned this Apr 1, 2026
@OleksiiKuzminov OleksiiKuzminov requested a review from a team as a code owner April 1, 2026 10:12
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant