Fix actionable notifications options #3954
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbirman
commented
Nov 23, 2025
|
|
||
| private extension PushNotificationManager { | ||
|
|
||
| func createNotificationCategories(from type: NotificationType) -> [UNNotificationCategory] { |
Member
Author
There was a problem hiding this comment.
It looks like the deleted code is duplicative of the methods in NotificationCategoryFactory.swift
Contributor
There was a problem hiding this comment.
Does NotificationCategoryFactory.shared.createCategories behave differently from the duplicate?
bbirman
commented
Nov 23, 2025
| UNNotificationAction( | ||
| identifier: action.identifier, | ||
| title: action.label, | ||
| options: [.foreground] // Ensures the app opens if needed |
Member
Author
There was a problem hiding this comment.
This is the line causing the issue and the updated logic is already in the other class here
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3954 +/- ##
==========================================
- Coverage 63.96% 63.30% -0.67%
==========================================
Files 252 252
Lines 22100 22080 -20
==========================================
- Hits 14137 13978 -159
- Misses 7963 8102 +139
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.