Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Links Redirect #560

Merged
merged 8 commits into from
Mar 6, 2025

Conversation

zshaian
Copy link
Contributor

@zshaian zshaian commented Mar 6, 2025

Pull Request Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: close #545

What is the new behavior?

now most of the external links are going to open a new tab instead of opening it in the same tab.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

vercel bot commented Mar 6, 2025

@zshaian is attempting to deploy a commit to the Niko Hoffrén's Team Team on Vercel.

A member of the Team first needs to authorize it.

@zshaian
Copy link
Contributor Author

zshaian commented Mar 6, 2025

i've also found this discussion in stack overflow

Update as of 2021: All current versions of major browsers now automatically use the behavior of rel="noopener" for any target="_blank" link, nullifying this issue. See more at chromestatus.com.

i still added the rel="noopener noreferrer" just to make sure

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fork-commit-merge-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 3:22pm

@nikohoffren nikohoffren merged commit 16ce6a4 into fork-commit-merge:main Mar 6, 2025
5 checks passed
@nikohoffren
Copy link
Member

Pull request merged

This is an automated message from Fork, Commit, Merge - web [BOT].

Thank you for your contribution! Your pull request has been merged and your name has been added to the List of Contributors in README.md.
Please leave a star if you enjoyed working on this project.

What's next?

If you're looking for more ways to contribute, I invite you to check out my other projects here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make every link to open in new tab
2 participants