63 implement cell by cell electrical model in fvs#75
Draft
goob10000 wants to merge 2 commits into
Draft
Conversation
goob10000
commented
Jun 1, 2026
Member
Author
goob10000
left a comment
goob10000
left a comment
There was a problem hiding this comment.
Pretty good job so far but missing some key elements!
Comment on lines
+113
to
+120
| for step in range(num_steps): | ||
| all_currents, module_voltage = module.step(pack_current, dt, capacity_Ah) | ||
| print(f"\nStep {step}") | ||
| print(f"Module Voltage: {module_voltage:.2f} V") | ||
|
|
||
| for g, group_currents in enumerate(all_currents): | ||
| print(f" Group {g}: {group_currents}") | ||
| print(f" Group {g} Sum: {np.sum(group_currents):.2f} A") No newline at end of file |
Member
Author
There was a problem hiding this comment.
I think we spoke about this already but make sure you're logging not just printing the values. Not only is it easier to process afterward but it is critical for your hysteresis calculation.
| soc = np.random.uniform(0.85, 0.95) | ||
| cells.append(Cell(soc=soc, resistance=resistances[h, w])) | ||
| groups.append(Parallel_Groups(cells)) | ||
| return Module(groups) |
Member
Author
There was a problem hiding this comment.
I see that you have internal cell resistances but I don't see where you implemented inter cell resistances. (horizontally if you imagine current mainly flowing vertically).
|
|
||
| def build_modules(width = 4, height = 2, resistances = None): | ||
| #if no given csv | ||
| if resistances is None: |
Member
Author
There was a problem hiding this comment.
To be clear, this is internal cell resistances right? Worth naming the variable more clearly because there are other resistors in the circuit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.