Open
Conversation
I originally authored this routine, which is updated for supported compilers. The logic selecting it in CMake was no longer relevant.
Member
|
I think there is some value in keeping the pre-Fortran 2018 error stop workaround. The current default branch still compiles with Intel 19, with this patch we would drop support for all Intel versions before 2021.3. Also, while Intel 2021.1 compiles stdlib, the support for Fortran 2018 error stop is buggy and will always report exit status 128 even if zero is passed as exit code. |
Member
|
@scivision can you explain in a sentence or two what this PR changes or improves? I understand the part about the more robust test driver. What is the tradeoff for dropping support for earlier Intel compilers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally authored this error_stop routine. The logic selecting it in CMake was no
longer relevant. I made a driver for the error stop test to make it more reliable.
oneAPI 2021.1 on MacOS has bugs breaking stdlib_error, so I update CI to latest oneAPI for MacOS.