hashmap-init-update #974
Merged
hashmap-init-update #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes code updates, doc, test and example updates for initialize update.
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Added code to update initialization flag at the end of the init routine.
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
|
Added the suggested changes. Also realized I forgot to update init so that it updates the initialization flag to true and added that. This PR is complete as far as I know. The last update shows a CI failure that is not related to hashmaps. |
jvdp1
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the hashmap initialization routine to be more user friendly. It does two things:
Changes hasher to be an optional argument instead of required, with the default being fnv_1_hasher if no hasher is specified.
This perhaps was the original intent of the code, as the abstract base hashmap class sets the hasher to fnv_1_hasher, but then the downstream init functions currently require the hasher to be specified again. I believe the choice of hasher function should be abstracted away for the majority of users.
Includes a logical flag
initializedto track initialized state, and if a map_entry call is made prior to initializing, it will call the init routine using default arguments.I believe this is a relatively simple ease of use feature, that will make the hashmaps more in line with implicit initialization commonly used with other languages (but init can still be explicitly called if needed).