Edited the teminal movements #9
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements cursor movement functionality in the terminal component, allowing users to navigate left and right within their input text and edit at any position.
- Added cursor position tracking with left/right arrow key navigation
- Enhanced backspace functionality to work with cursor positioning
- Implemented text insertion at cursor position for both regular characters and spaces
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| term.write(`\x1b[${charsToMoveBack}D`); | ||
| } | ||
| } | ||
| else if(domEvent.key == 'ArrowLeft'){ |
There was a problem hiding this comment.
Use strict equality (===) instead of loose equality (==) for comparison. This prevents type coercion issues and follows JavaScript best practices.
| else if(domEvent.key == 'ArrowLeft'){ | |
| else if(domEvent.key === 'ArrowLeft'){ |
| term.write('\x1b[D'); | ||
| } | ||
| } | ||
| else if(domEvent.key == 'ArrowRight'){ |
There was a problem hiding this comment.
Use strict equality (===) instead of loose equality (==) for comparison. This prevents type coercion issues and follows JavaScript best practices.
| else if(domEvent.key == 'ArrowRight'){ | |
| else if(domEvent.key === 'ArrowRight'){ |
| else if(domEvent.key == 'ArrowLeft'){ | ||
| if(cursorPos > 0){ | ||
| cursorPos--; | ||
| term.write('\x1b[D'); | ||
| } | ||
| } | ||
| else if(domEvent.key == 'ArrowRight'){ | ||
| if(cursorPos < input.length){ | ||
| cursorPos++; | ||
| term.write('\x1b[C'); | ||
| } | ||
| } |
There was a problem hiding this comment.
Inconsistent spacing around parentheses and braces. Add spaces after 'if' and around parentheses for consistency with the rest of the codebase.
|
|
||
| let input = ''; | ||
| let currentDir = 'home'; | ||
| let cursorPos = 0; |
There was a problem hiding this comment.
The cursorPos variable should be reset to 0 when input is cleared (after Enter key is pressed) to maintain proper cursor positioning for new commands.
1 participant
edited the terminal movement like moving left and right in the terminal . and editing the text after movement.