Skip to content

Commit d6460c3

Browse files
arc: Improve warning when breakpoint has been overwritten
Signed-off-by: Anton Kolesov <[email protected]>
1 parent fa00da3 commit d6460c3

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/target/arc_dbg.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,10 @@ static int arc_dbg_unset_breakpoint(struct target *target,
198198
if (retval != ERROR_OK)
199199
return retval;
200200
} else {
201-
LOG_WARNING("Software breakpoint @%" PRIx32
202-
" has been overwritten outside of debugger.", breakpoint->address);
201+
LOG_WARNING("Software breakpoint @0x%" PRIx32
202+
" has been overwritten outside of debugger."
203+
"Expected: 0x%08" PRIx32 ", got: 0x%08" PRIx32,
204+
breakpoint->address, ARC32_SDBBP, current_instr);
203205
}
204206
} else if (breakpoint->length == 2) {
205207
uint16_t current_instr;
@@ -216,8 +218,10 @@ static int arc_dbg_unset_breakpoint(struct target *target,
216218
if (retval != ERROR_OK)
217219
return retval;
218220
} else {
219-
LOG_WARNING("Software breakpoint @%" PRIx32
220-
" has been overwritten outside of debugger.", breakpoint->address);
221+
LOG_WARNING("Software breakpoint @0x%" PRIx32
222+
" has been overwritten outside of debugger. "
223+
"Expected: 0x%04" PRIx16 ", got: 0x%04" PRIx16,
224+
breakpoint->address, ARC16_SDBBP, current_instr);
221225
}
222226
} else {
223227
LOG_ERROR("Invalid breakpoint length: target supports only 2 or 4");

0 commit comments

Comments
 (0)