-
Notifications
You must be signed in to change notification settings - Fork 111
This removes the unnecessary variable INSTALL which has the same value as the recipe variable - (Solves- #437) #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranav1698 according to #121 we have to keep chrome also as an option.
@tabesin @xeon-zolt do we need chrome even after we are already adding chromium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabesin @xeon-zolt @meets2tarun please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you (plan to) do with the
INSTALL_xyz
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabesin @meets2tarun @xeon-zolt please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabesin please review, this is open for a long time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranav1698 wait for some time I will create a PR for full working 3rd party software installation. I'm busy in my semester final exams.
You can change this PR by removing the old way of getting the response of checkbox and please don't remove the chrome checkbox (refer #121)
chromium and chrome are the same things |
Through meilix-generator we are providing an option for users to choose his/her own browser, so providing an option for chrome also should not be a problem. |
@tabesin @xeon-zolt @meets2tarun please review it again |
ok, lets have a look, thanks for the notification @rpotter12 |
Checklist
master
branch.Short description of what this resolves:
This solves the unexpected error
Sorry, unexpected error: str expected, not list
,The INSTALL array was not required, the value of the array is same as the recipe array but with different names, I have made the changes equivalent to what we were doing previously
Check one of the meilix builds triggered by the webapp and notice that the recipe array is already sending the 3rd party softwares into the build server
Changes proposed in this pull request:
Fixes #437