Skip to content

Conversation

marcnause
Copy link
Contributor

@marcnause marcnause commented Oct 12, 2025

Fixes: #2962

Requires testing with phone and PSLab device.

Summary by Sourcery

Build:

  • Switch usb_serial dependency from Git master to version ^0.5.0 on pub.dev

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR replaces the usb_serial dependency sourced from a GitHub repository with the published ^0.5.0 version on pub.dev, updating both pubspec.yaml and the lock file accordingly.

File-Level Changes

Change Details Files
Switch usb_serial dependency from GitHub to pub.dev version
  • Removed git URL and ref block for usb_serial
  • Added usb_serial: ^0.5.0 under dependencies
  • Regenerated pubspec.lock to capture the new version
pubspec.yaml
pubspec.lock

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@marcnause marcnause force-pushed the replaceUsbSerialDependency branch from a8b0d32 to 2d547df Compare October 12, 2025 16:31
@github-actions
Copy link
Contributor

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/18446588839/artifacts/4248784139.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

@marcnause marcnause self-assigned this Oct 12, 2025
@marcnause
Copy link
Contributor Author

I have tested the APK with my phone and the PSLab v6 board. As far as I can tell, communication worked without problems.

@marcnause marcnause marked this pull request as ready for review October 18, 2025 16:23
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

usb_serial is pulled from git instead of pub.dev

2 participants